Source/core/rendering/RenderFlowThread.h - Issue 18374008: Propagate writing-mode from the first region to the flow thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlowThread.h

Issue 18374008: Propagate writing-mode from the first region to the flow thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/regions/changing-writing-mode-5.html ('K') | « LayoutTests/fast/regions/subtree-with-vert-rl-expected.html ('k') | Source/core/rendering/RenderFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderFlowThread.h

diff --git a/Source/core/rendering/RenderFlowThread.h b/Source/core/rendering/RenderFlowThread.h

index 27ea3acc7d447c6ea71bedc17c0a483f60a850a7..3f3877f60436ae8b69d797b3f727faac1fe31b74 100644

--- a/Source/core/rendering/RenderFlowThread.h

+++ b/Source/core/rendering/RenderFlowThread.h

@@ -87,6 +87,7 @@ public:

// Check if the content is flown into at least a region with region styling rules.

bool hasRegionsWithStyling() const { return m_hasRegionsWithStyling; }

void checkRegionsWithStyling();

+ virtual void regionChangedWritingMode(RenderRegion* region) { }

esprehn 2013/08/08 03:10:39 leave off "region", it adds no value.

mstensho (USE GERRIT) 2013/08/08 06:51:50 Done.

void validateRegions();

void invalidateRegions();