LayoutTests/fast/regions/changing-writing-mode.html - Issue 18374008: Propagate writing-mode from the first region to the flow thread.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/regions/changing-writing-mode.html

Issue 18374008: Propagate writing-mode from the first region to the flow thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Changing writing mode on the first region</title>

	5 </head>

	6 <body style="color:black; background:white;">

	7 <p>Below you should see the word 'PASS' on a lime background.</p>

	8 <div id="container" style="width:20em; height:20em; line-height:2em;">

	9 <div style="-webkit-flow-into:thread;">

	10 <br>

	11 <div style="-webkit-region-break-after:always;"></div>

	12 <div style="-webkit-writing-mode:horizontal-tb;">PASS</div>

	13 </div>

	14 <div style="-webkit-flow-from:thread; background:black;"></div>

	15 <div style="-webkit-flow-from:thread; background:lime;"></div>

	16 </div>

	17 <script>

	18 container.offsetLeft; // Make sure we have laid out.
	esprehn 2013/08/08 03:10:39 Please don't access vars like this: var container Please don't access vars like this: var container = document.getElementById('container'); mstensho (USE GERRIT) 2013/08/08 06:51:50 I did "document.getElementById('container').offset Show quoted text On 2013/08/08 03:10:39, esprehn wrote: > Please don't access vars like this: > var container = document.getElementById('container'); I did "document.getElementById('container').offsetLeft" etc. instead. Hope that's fine. BTW, I'd like to know why it's a problem to address elements directly, like I did. Engine compatibility? I seem to remember that it doesn't work everywhere. Gecko?
	19 container.style.WebkitWritingMode = 'vertical-rl';

	20 </script>

	21 </body>

	22 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/regions/changing-writing-mode-2.html » ('j') | LayoutTests/fast/regions/changing-writing-mode-5.html » ('J')