Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1837393003: [turbofan] Fix CodeStubAssembler::ChangeFloat64ToTagged for 32-bit. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix CodeStubAssembler::ChangeFloat64ToTagged for 32-bit. Remove the duplicate if_join label (thanks C++ for not even emitting a warning about this). R=mtrofin@chromium.org Committed: https://crrev.com/48561ef6adc6841c8f55c3c60718ad71a4adace3 Cr-Commit-Position: refs/heads/master@{#35122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/code-stub-assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-03-30 03:53:30 UTC) #1
Benedikt Meurer
Hey Mircea, Here's the quickfix for ChangeFloat64ToTagged. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-03-30 03:54:02 UTC) #2
Mircea Trofin
On 2016/03/30 03:54:02, Benedikt Meurer wrote: > Hey Mircea, > > Here's the quickfix for ...
4 years, 8 months ago (2016-03-30 04:00:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837393003/1
4 years, 8 months ago (2016-03-30 04:00:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 04:14:59 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 04:16:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48561ef6adc6841c8f55c3c60718ad71a4adace3
Cr-Commit-Position: refs/heads/master@{#35122}

Powered by Google App Engine
This is Rietveld 408576698