Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1837353002: Mojom parser: Fix snippet algorithm. (Closed)

Created:
4 years, 8 months ago by rudominer
Modified:
4 years, 8 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom parser: Fix snippet algorithm.. Line 269 of tokens.go was not being tested and it had a bug that causes a panic when attempting to compute the snippet for a token at the end of a long line. This patch fixes the bug and adds a test for it. The .mojom.dart files definitely should not have changed so I think there must be some unrelated bug in the stability of the runtime type info generation that I will have to investigate. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46d96856e1e5882491cb4a2fcda1eeeb108f2bdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_included_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/lexer/lexer_test.go View 1 chunk +20 lines, -0 lines 0 comments Download
M mojom/mojom_parser/lexer/tokens.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
rudominer
Hi Alex, ptal.
4 years, 8 months ago (2016-03-29 22:37:55 UTC) #3
azani
lgtm
4 years, 8 months ago (2016-03-29 22:41:37 UTC) #4
rudominer
4 years, 8 months ago (2016-03-29 22:49:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
46d96856e1e5882491cb4a2fcda1eeeb108f2bdb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698