[Extensions] Support choices in autogenerated movable types

[Extensions] Support choices in autogenerated movable types

Choices were left out of our movable type generation. Add them, and add a test.

BUG=595949
Committed: https://crrev.com/f48f9852d1ffdffa967cca7a25e7be2f7718b077
Cr-Commit-Position: refs/heads/master@{#384443}

[Devlin, 2016-03-31 03:30:55]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-03-31 03:30:56]

Antony, mind taking a look? Kind of surprising none of our tests caught this...

[asargent_no_longer_on_chrome, 2016-03-31 21:56:34]

lgtm

https://codereview.chromium.org/1837293004/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/test/objects_unittest.cc (right):

https://codereview.chromium.org/1837293004/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/test/objects_unittest.cc:114: EXPECT_EQ("string",
*parent2.choice.as_string);
maybe also add a test of as_movable_pod?

[Devlin, 2016-04-01 00:09:01]

https://codereview.chromium.org/1837293004/diff/1/tools/json_schema_compiler/...
File tools/json_schema_compiler/test/objects_unittest.cc (right):

https://codereview.chromium.org/1837293004/diff/1/tools/json_schema_compiler/...
tools/json_schema_compiler/test/objects_unittest.cc:114: EXPECT_EQ("string",
*parent2.choice.as_string);
On 2016/03/31 21:56:34, Antony Sargent wrote:
> maybe also add a test of as_movable_pod?

Done.

[Devlin, 2016-04-01 00:09:04]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-04-01 00:09:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1837293004/#ps20001
(title: "Moar tests")

[commit-bot: I haz the power, 2016-04-01 00:09:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837293004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837293004/20001

[commit-bot: I haz the power, 2016-04-01 00:16:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-01 00:17:17]

Description was changed from

==========
[Extensions] Support choices in autogenerated movable types

Choices were left out of our movable type generation. Add them, and add a test.

BUG=595949
==========

to

==========
[Extensions] Support choices in autogenerated movable types

Choices were left out of our movable type generation. Add them, and add a test.

BUG=595949

Committed: https://crrev.com/f48f9852d1ffdffa967cca7a25e7be2f7718b077
Cr-Commit-Position: refs/heads/master@{#384443}
==========

[commit-bot: I haz the power, 2016-04-01 00:17:18]

Patchset 2 (id:??) landed as
https://crrev.com/f48f9852d1ffdffa967cca7a25e7be2f7718b077
Cr-Commit-Position: refs/heads/master@{#384443}