Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1837293003: Revert of Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp (Closed)

Created:
4 years, 8 months ago by djsollen
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp (patchset #6 id:100001 of https://codereview.chromium.org/1842793002/ ) Reason for revert: This CL is causing the autoroll into Chromium & google3 to fail. Original issue's description: > Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp > > TBR=reed@google.com > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842793002 > > Committed: https://skia.googlesource.com/skia/+/a33cf07a2273315363c0b6fb5d3ce811742f5a85 TBR=fmalita@chromium.org,reed@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/890579051d4096a8f769eadb9cde3f931d7abd7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -272 lines) Patch
M gm/imagefiltersclipped.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/localmatriximagefilter.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M include/core/SkImageFilter.h View 2 chunks +2 lines, -10 lines 0 comments Download
M include/effects/SkPaintImageFilter.h View 1 chunk +1 line, -9 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 7 chunks +114 lines, -186 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 3 chunks +4 lines, -20 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.h View 2 chunks +2 lines, -19 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.cpp View 2 chunks +16 lines, -5 lines 0 comments Download
M src/effects/SkPaintImageFilter.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M tests/PaintImageFilterTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
djsollen
Created Revert of Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp
4 years, 8 months ago (2016-03-30 02:06:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837293003/1
4 years, 8 months ago (2016-03-30 02:07:00 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 02:07:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/890579051d4096a8f769eadb9cde3f931d7abd7c

Powered by Google App Engine
This is Rietveld 408576698