Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1837263005: cc: Rename DisplayListRasterSource to just RasterSource. (Closed)

Created:
4 years, 8 months ago by vmpstr
Modified:
4 years, 8 months ago
Reviewers:
wkorman, enne (OOO)
CC:
wkorman, cc-bugs_chromium.org, chrishtr, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename DisplayListRasterSource to just RasterSource. DisplayListRasterSource used to derive from RasterSource and there was another implementation. However, currently there's only one raster source and it doesn't derive from any common interface. Rename it to just be the RasterSource. R=enne CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/41d68f8898876f784d7d33201318612db521289b Cr-Commit-Position: refs/heads/master@{#383887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -2031 lines) Patch
M cc/BUILD.gn View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/cc.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 3 chunks +3 lines, -5 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 58 chunks +167 lines, -175 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 11 chunks +21 lines, -31 lines 0 comments Download
D cc/playback/display_list_raster_source.h View 1 chunk +0 lines, -177 lines 0 comments Download
D cc/playback/display_list_raster_source.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D cc/playback/display_list_raster_source_unittest.cc View 1 chunk +0 lines, -553 lines 0 comments Download
M cc/playback/display_list_recording_source.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/playback/display_list_recording_source.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M cc/playback/display_list_recording_source_unittest.cc View 8 chunks +12 lines, -12 lines 0 comments Download
A + cc/playback/raster_source.h View 5 chunks +14 lines, -17 lines 0 comments Download
A + cc/playback/raster_source.cc View 12 chunks +54 lines, -69 lines 0 comments Download
A + cc/playback/raster_source_unittest.cc View 22 chunks +43 lines, -44 lines 0 comments Download
M cc/quads/draw_quad_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/quads/picture_draw_quad.h View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/quads/picture_draw_quad.cc View 2 chunks +23 lines, -25 lines 0 comments Download
M cc/raster/bitmap_tile_task_worker_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/raster/gpu_rasterizer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/raster/gpu_rasterizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/raster/raster_buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/raster/tile_task_worker_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/raster/tile_task_worker_pool.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
D cc/test/fake_display_list_raster_source.h View 1 chunk +0 lines, -63 lines 0 comments Download
D cc/test/fake_display_list_raster_source.cc View 1 chunk +0 lines, -160 lines 0 comments Download
M cc/test/fake_display_list_recording_source.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_display_list_recording_source.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 6 chunks +9 lines, -10 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A cc/test/fake_raster_source.h View 1 chunk +57 lines, -0 lines 0 comments Download
A + cc/test/fake_raster_source.cc View 6 chunks +36 lines, -41 lines 0 comments Download
M cc/tiles/picture_layer_tiling.h View 5 chunks +6 lines, -7 lines 0 comments Download
M cc/tiles/picture_layer_tiling.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/tiles/picture_layer_tiling_perftest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/tiles/picture_layer_tiling_set.h View 3 chunks +6 lines, -7 lines 0 comments Download
M cc/tiles/picture_layer_tiling_set.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/tiles/picture_layer_tiling_set_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M cc/tiles/picture_layer_tiling_unittest.cc View 29 chunks +59 lines, -65 lines 0 comments Download
M cc/tiles/prioritized_tile.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/tiles/prioritized_tile.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M cc/tiles/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 17 chunks +38 lines, -38 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
enne (OOO)
What about recording source?
4 years, 8 months ago (2016-03-29 22:44:54 UTC) #2
vmpstr
Please take a look. I'll do the recording source as a follow up!
4 years, 8 months ago (2016-03-29 22:49:37 UTC) #4
enne (OOO)
lgtm to do recording source as a follow-up PS for posterity I would like to ...
4 years, 8 months ago (2016-03-29 22:55:49 UTC) #5
wkorman
Casting a spell of 'Inflict Merge Pain, Level 3'. :) Perhaps it will auto-merge...
4 years, 8 months ago (2016-03-29 23:03:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837263005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837263005/1
4 years, 8 months ago (2016-03-29 23:21:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 01:20:34 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:21:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d68f8898876f784d7d33201318612db521289b
Cr-Commit-Position: refs/heads/master@{#383887}

Powered by Google App Engine
This is Rietveld 408576698