src/s390/simulator-s390.cc - Issue 1837263003: S390: Fix SQEBR sim to treat operands as float32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/s390/simulator-s390.cc

Issue 1837263003: S390: Fix SQEBR sim to treat operands as float32 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/s390/simulator-s390.cc

diff --git a/src/s390/simulator-s390.cc b/src/s390/simulator-s390.cc

index d3e19d857231b7a902453daab326cb530dbe6118..5d50b615a11627ffde1b8a611d90210759b0fc8d 100644

--- a/src/s390/simulator-s390.cc

+++ b/src/s390/simulator-s390.cc

@@ -3437,8 +3437,8 @@ bool Simulator::DecodeFourByteFloatingPoint(Instruction* instr) {

r1_val = std::sqrt(r2_val);

set_d_register_from_double(r1, r1_val);

} else if (op == SQEBR) {

- r1_val = std::sqrt(r2_val);

- set_d_register_from_float32(r1, r1_val);

+ fr1_val = std::sqrt(fr2_val);

+ set_d_register_from_float32(r1, fr1_val);

} else if (op == CFEBR) {

DecodeFourByteFloatingPointRound(instr);

} else if (op == LCDBR) {

« no previous file with comments | « src/s390/disasm-s390.cc ('k') | no next file » | no next file with comments »