Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1837263003: S390: Fix SQEBR sim to treat operands as float32 (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix SQEBR sim to treat operands as float32 Fix bug in simulator which incorrectly interpreted the operands for SQEBR (Float32 sqrt) as 64-bit doubles. Add missing disassembler case for SQEBR as well. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/5ac8e667bf1add7f694c18852e396ed606f97e39 Cr-Commit-Position: refs/heads/master@{#35119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/s390/disasm-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
JoranSiu
PTAL
4 years, 8 months ago (2016-03-29 20:34:08 UTC) #1
john.yan
lgtm
4 years, 8 months ago (2016-03-29 20:40:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837263003/1
4 years, 8 months ago (2016-03-29 20:43:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 21:03:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837263003/1
4 years, 8 months ago (2016-03-29 21:07:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 21:08:47 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:10:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ac8e667bf1add7f694c18852e396ed606f97e39
Cr-Commit-Position: refs/heads/master@{#35119}

Powered by Google App Engine
This is Rietveld 408576698