Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1837253002: bluetooth: Change definition of WebBluetoothError to mojo enum (Closed)

Created:
4 years, 8 months ago by ortuno
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Change definition of WebBluetoothError to mojo enum To avoid having duplicated code to handle the new mojo enum we move all the values from WebBluetoothError to mojom::WebBluetoothError and change WebBluetoothError.h to use the generated enum. BUG=508771 Committed: https://crrev.com/8a1df599dd1bc05a91140bbbb329f724f28b4d7e Cr-Commit-Position: refs/heads/master@{#384107}

Patch Set 1 #

Messages

Total messages: 13 (5 generated)
ortuno
rockot: PTAL
4 years, 8 months ago (2016-03-29 17:13:36 UTC) #2
Jeffrey Yasskin
lgtm
4 years, 8 months ago (2016-03-29 20:35:30 UTC) #4
Ken Rockot(use gerrit already)
\o/ LGTM
4 years, 8 months ago (2016-03-29 20:39:57 UTC) #5
ortuno
palmer: PTAL
4 years, 8 months ago (2016-03-29 20:45:33 UTC) #7
palmer
lgtm
4 years, 8 months ago (2016-03-30 21:53:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837253002/1
4 years, 8 months ago (2016-03-30 21:58:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 22:04:47 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 22:07:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a1df599dd1bc05a91140bbbb329f724f28b4d7e
Cr-Commit-Position: refs/heads/master@{#384107}

Powered by Google App Engine
This is Rietveld 408576698