chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 1837243002: Reader Mode support for low-end devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1837243002: Reader Mode support for low-end devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: swipe triggers custom tab Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index 91b67cb03abefcc501b2498ea3e6e03e6c27367b..902fb4ebb8978af2662dfb9b2b6e3b2e7463cb6d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -46,6 +46,7 @@ import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChange

import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument;

import org.chromium.chrome.browser.datausage.DataUseTabUIManager;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

+import org.chromium.chrome.browser.dom_distiller.ReaderModeManager;

import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;

import org.chromium.chrome.browser.rappor.RapporServiceBridge;

import org.chromium.chrome.browser.tab.Tab;

@@ -391,6 +392,11 @@ public class CustomTabActivity extends ChromeActivity {

public void initializeCompositor() {

super.initializeCompositor();

getTabModelSelector().onNativeLibraryReady(getTabContentManager());

+ // Notify Reader Mode that this is a custom tab.

+ if (ReaderModeManager.isEnabled(this)) {

+ mReaderModeManager.setIsCustomTab();

+ getToolbarManager().setUrlBarHidden(true);

+ }

}

private void recordClientPackageName() {