Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2788)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 1837243002: Reader Mode support for low-end devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: swipe triggers custom tab Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
index deaff7e0d20424faca4cd5f5cbb6f0b50c28f9b5..52ec7e87f72891fff12340e80dfbb34cf2aab3c0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
@@ -631,7 +631,7 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState
mHasDetectedTouchGesture = true;
if (isCoordinateInsideBasePage(x, y)) {
closePanel(StateChangeReason.BASE_PAGE_TAP, true);
- } else if (isCoordinateInsideBar(x, y) && !onInterceptBarClick()) {
+ } else if (isCoordinateInsideBar(x, y) && !onInterceptBarClick(x, y)) {
handleBarClick(time, x, y);
}
}
@@ -651,9 +651,11 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState
/**
* Allows the click on the bar to be intercepted.
+ * @param x The x coordinate of the gesture.
+ * @param y The y coordinate of the gesture.
* @return True if the click on the bar was intercepted by this function.
*/
- protected boolean onInterceptBarClick() {
+ protected boolean onInterceptBarClick(float x, float y) {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698