Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1837233005: Add a base dependency to browsing_data_ui. (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a base dependency to browsing_data_ui. This is necessary, since we're using base::Callback. BUG=595332 Committed: https://crrev.com/46dcfc017b72cf34e1de7152c3cd42dcad573ecd Cr-Commit-Position: refs/heads/master@{#384209}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/browsing_data_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/browsing_data_ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
msramek
Hi Colin, please have a look! I have recently added a base::Callback to this component, ...
4 years, 8 months ago (2016-03-30 19:35:10 UTC) #3
blundell
lgtm
4 years, 8 months ago (2016-03-31 07:22:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837233005/20001
4 years, 8 months ago (2016-03-31 07:22:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-03-31 07:27:31 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 07:28:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46dcfc017b72cf34e1de7152c3cd42dcad573ecd
Cr-Commit-Position: refs/heads/master@{#384209}

Powered by Google App Engine
This is Rietveld 408576698