Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: components/page_load_metrics/common/page_load_timing.h

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added dcheck when isHighResolution is true. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/common/page_load_timing.h
diff --git a/components/page_load_metrics/common/page_load_timing.h b/components/page_load_metrics/common/page_load_timing.h
index 4cbe9faa17d56afcd00e2f34141afc194e61d163..a61551d4a402d20a48b138a6b65bbef78dcc2da7 100644
--- a/components/page_load_metrics/common/page_load_timing.h
+++ b/components/page_load_metrics/common/page_load_timing.h
@@ -28,6 +28,12 @@ struct PageLoadTiming {
// All TimeDeltas are relative to navigation_start
+ // TODO(shivanisha): Issue 596367 shows that it is possible for a valid
+ // TimeDelta value to be 0 (2 TimeTicks can have the same value even if they
+ // were assigned in separate instructions if the clock speed is less
+ // granular). The solution there was to use base::Optional for those values.
+ // Consider changing the below values to Optional as well.
+
// Time that the first byte of the response is received.
base::TimeDelta response_start;
« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_util.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698