Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added dcheck when isHighResolution is true. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_observer.cc
diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.cc b/components/page_load_metrics/browser/page_load_metrics_observer.cc
index 68de4d49fd291113c88d8f49c790a1a5c4a524db..98ffef5cdf6f2557326beeb6082cfe5f10e8d9bd 100644
--- a/components/page_load_metrics/browser/page_load_metrics_observer.cc
+++ b/components/page_load_metrics/browser/page_load_metrics_observer.cc
@@ -6,14 +6,15 @@
namespace page_load_metrics {
-PageLoadExtraInfo::PageLoadExtraInfo(base::TimeDelta first_background_time,
- base::TimeDelta first_foreground_time,
- bool started_in_foreground,
- const GURL& committed_url,
- base::TimeDelta time_to_commit,
- UserAbortType abort_type,
- base::TimeDelta time_to_abort,
- const PageLoadMetadata& metadata)
+PageLoadExtraInfo::PageLoadExtraInfo(
+ const base::Optional<base::TimeDelta>& first_background_time,
+ const base::Optional<base::TimeDelta>& first_foreground_time,
+ bool started_in_foreground,
+ const GURL& committed_url,
+ const base::Optional<base::TimeDelta>& time_to_commit,
+ UserAbortType abort_type,
+ const base::Optional<base::TimeDelta>& time_to_abort,
+ const PageLoadMetadata& metadata)
: first_background_time(first_background_time),
first_foreground_time(first_foreground_time),
started_in_foreground(started_in_foreground),
@@ -25,4 +26,5 @@ PageLoadExtraInfo::PageLoadExtraInfo(base::TimeDelta first_background_time,
PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default;
+PageLoadExtraInfo::~PageLoadExtraInfo() {}
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698