chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.cc - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added dcheck when isHighResolution is true. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.cc

index 1eba05b461a9a4a5e29676264ed5ef587e090ee8..02c25e74deaa8a18a8fcfe25b48316199bc352d2 100644

--- a/chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.cc

@@ -38,8 +38,7 @@ void HttpsEngagementPageLoadMetricsObserver::OnShown() {

void HttpsEngagementPageLoadMetricsObserver::OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) {

- if (!extra_info.committed_url.is_valid() ||

- extra_info.time_to_commit.is_zero())

+ if (!extra_info.committed_url.is_valid() || !extra_info.time_to_commit)

return;

// Don't record anything if the user never saw it.