Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4485)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments incorporation Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 4c101f6009c02663d45ae3a1f911a2ca88a14461..426aeb5470de33319b4e8dec832b291c27d406ac 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -128,14 +128,16 @@ void AbortsPageLoadMetricsObserver::OnComplete(
if (abort_type == UserAbortType::ABORT_NONE)
return;
- base::TimeDelta time_to_abort = extra_info.time_to_abort;
- DCHECK(!time_to_abort.is_zero());
+ DCHECK(extra_info.time_to_abort);
// Don't log abort times if the page was backgrounded before the abort event.
- if (!WasStartedInForegroundEventInForeground(time_to_abort, extra_info))
+ if (!WasStartedInForegroundOptionalEventInForeground(extra_info.time_to_abort,
+ extra_info))
return;
- if (extra_info.time_to_commit.is_zero()) {
+ const base::TimeDelta& time_to_abort = extra_info.time_to_abort.value();
+
+ if (!extra_info.time_to_commit) {
RecordAbortBeforeCommit(abort_type, time_to_abort);
return;
}

Powered by Google App Engine
This is Rietveld 408576698