Optional <TimeDelta> since they may be non existent.

chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index ed9428b122096dd3382552eb2ea0eeeade788bad..9d015355fb27297041fae6ef6384eb691837fd5d 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -178,14 +178,16 @@ void AbortsPageLoadMetricsObserver::OnComplete(
   if (abort_type == UserAbortType::ABORT_NONE)
     return;
 
-  base::TimeDelta time_to_abort = extra_info.time_to_abort;
-  DCHECK(!time_to_abort.is_zero());
+  DCHECK(extra_info.time_to_abort);

[Charlie Harrison, 2016/05/19 18:20:48]

Just to confirm. Does DCHECKing an Optional check to make sure it has a value?

[shivanisha, 2016/05/23 15:06:43]

That's right.

 
   // Don't log abort times if the page was backgrounded before the abort event.
-  if (!WasStartedInForegroundEventInForeground(time_to_abort, extra_info))
+  if (!WasStartedInForegroundOptionalEventInForeground(extra_info.time_to_abort,
+                                                       extra_info))
     return;
 
-  if (extra_info.time_to_commit.is_zero()) {
+  const base::TimeDelta& time_to_abort = extra_info.time_to_abort.value();
+
+  if (!extra_info.time_to_commit) {
     RecordAbortBeforeCommit(abort_type, time_to_abort);
     return;
   }