Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: components/page_load_metrics/common/page_load_timing.h

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Need to add Optional changes as well in this issue otherwise bots fail in compilation Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/common/page_load_timing.h
diff --git a/components/page_load_metrics/common/page_load_timing.h b/components/page_load_metrics/common/page_load_timing.h
index 285cf65aa3b946cf78d7c4ed430ca69ac6fcf65b..56b55efb5bd1b63ed14f2dd0fa117c605437dfdd 100644
--- a/components/page_load_metrics/common/page_load_timing.h
+++ b/components/page_load_metrics/common/page_load_timing.h
@@ -26,6 +26,13 @@ struct PageLoadTiming {
// All TimeDeltas are relative to navigation_start
+ // @shivanisha TODO Issue 596367 shows that it is possible for a existent
Bryan McQuade 2016/03/29 18:33:43 style nit: TODO(shivanisha): Issue ...
shivanisha 2016/03/29 18:54:25 updating the comment
+ // TimeDelta value to be 0 (2 TimeTicks can have the same value even if they
+ // were assigned in separate instructions if the clock speed is less
+ // granular). The solution there was to use base::Optional for those values.
+ // Consider changing the below values to Optional as well when serialization
+ // supports it.
+
// Time that the first byte of the response is received.
base::TimeDelta response_start;

Powered by Google App Engine
This is Rietveld 408576698