components/page_load_metrics/browser/metrics_web_contents_observer.h - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Need to add Optional changes as well in this issue otherwise bots fail in compilation Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/optional_unittest.cc ('K') | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | components/page_load_metrics/browser/page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.h

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.h b/components/page_load_metrics/browser/metrics_web_contents_observer.h

index aaac42e6bb0fb3f11f22f28d1b2f5e9dca6cba59..4f38690508c75a80aabf987f3c01512380a1aa81 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.h

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.h

@@ -152,7 +152,7 @@ class PageLoadTracker {

bool MatchesOriginalNavigation(content::NavigationHandle* navigation_handle);

private:

- PageLoadExtraInfo GetPageLoadMetricsInfo();

+ PageLoadExtraInfo ComputePageLoadExtraInfo();

// Only valid to call post-commit.

const GURL& committed_url();