chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Need to add Optional changes as well in this issue otherwise bots fail in compilation Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/optional_unittest.cc ('K') | « chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | components/page_load_metrics/browser/page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

index f59d5db0be8e8d8f980d886aa6a50572644adeee..c98995b2a9b17c8cc9ddf168f426bd4a2894658d 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

@@ -54,10 +54,11 @@ class CorePageLoadMetricsObserver

// Information related to failed provisional loads.

// Populated in OnFailedProvisionalLoad and accessed in OnComplete.

struct FailedProvisionalLoadInfo {

- base::TimeDelta interval;

+ base::Optional<base::TimeDelta> interval;

net::Error error;

- FailedProvisionalLoadInfo() : error(net::OK) {}

+ FailedProvisionalLoadInfo();

+ ~FailedProvisionalLoadInfo();

};

void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,