base/base.gyp - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Need to add Optional changes as well in this issue otherwise bots fail in compilation Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index 25918035bcba6d60d1ef3bbdf35c1913cbabf671..68bda0b1979428a3a1a685d70a63c7afee9e4368 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -500,6 +500,7 @@

'native_library_unittest.cc',

shivanisha 2016/03/29 17:32:06 Ignore this file for review. Added here for compil

'numerics/safe_numerics_unittest.cc',

'observer_list_unittest.cc',

+ 'optional_unittest.cc',

'os_compat_android_unittest.cc',

'path_service_unittest.cc',

'pickle_unittest.cc',

« base/BUILD.gn ('K') | « base/BUILD.gn ('k') | base/base.gypi » ('j') | base/base.gypi » ('J')