base/BUILD.gn - Issue 1837233002: Optional <TimeDelta> since they may be non existent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Need to add Optional changes as well in this issue otherwise bots fail in compilation Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index ec259fd99008efd71086ab0e9888e0f5a57c925e..6b6d7c1d9ab8e4ad7163efc71d0e5fdb45602d89 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -565,6 +565,7 @@ component("base") {

"numerics/safe_math_impl.h",

"observer_list.h",

"observer_list_threadsafe.h",

shivanisha 2016/03/29 17:32:06 Ignore this file for review. Added here for compil

+ "optional.h",

"os_compat_android.cc",

"os_compat_android.h",

"os_compat_nacl.cc",

@@ -1771,6 +1772,7 @@ test("base_unittests") {

"native_library_unittest.cc",

"numerics/safe_numerics_unittest.cc",

"observer_list_unittest.cc",

+ "optional_unittest.cc",

"os_compat_android_unittest.cc",

"path_service_unittest.cc",

"pickle_unittest.cc",

« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/base.gyp » ('J')