Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_util.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added dcheck when isHighResolution is true. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 5 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
10 #include "components/page_load_metrics/common/page_load_timing.h" 10 #include "components/page_load_metrics/common/page_load_timing.h"
11 11
12 namespace page_load_metrics { 12 namespace page_load_metrics {
13 13
14 bool WasStartedInForegroundEventInForeground(base::TimeDelta event, 14 bool WasStartedInForegroundEventInForeground(base::TimeDelta event,
15 const PageLoadExtraInfo& info) { 15 const PageLoadExtraInfo& info) {
16 return info.started_in_foreground && !event.is_zero() && 16 return info.started_in_foreground && !event.is_zero() &&
17 (info.first_background_time.is_zero() || 17 (!info.first_background_time ||
18 event < info.first_background_time); 18 event <= info.first_background_time.value());
19 }
20
21 // TODO (shivanisha) The above function is used for TimeDeltas coming over IPC.
22 // Merge these two when page_load_metrics only handles Optional TimeDelta
23 // values in the browser process.
24 bool WasStartedInForegroundOptionalEventInForeground(
25 const base::Optional<base::TimeDelta>& event,
26 const PageLoadExtraInfo& info) {
27 return info.started_in_foreground && event &&
28 (!info.first_background_time ||
29 event.value() <= info.first_background_time.value());
19 } 30 }
20 31
21 bool WasParseInForeground(base::TimeDelta parse_start, 32 bool WasParseInForeground(base::TimeDelta parse_start,
22 base::TimeDelta parse_stop, 33 base::TimeDelta parse_stop,
23 const PageLoadExtraInfo& info) { 34 const PageLoadExtraInfo& info) {
24 if (parse_start.is_zero()) { 35 if (parse_start.is_zero()) {
25 return false; 36 return false;
26 } 37 }
27 const bool incomplete_parse_in_foreground = 38 const bool incomplete_parse_in_foreground = parse_stop.is_zero() &&
28 parse_stop.is_zero() && info.started_in_foreground && 39 info.started_in_foreground &&
29 info.first_background_time.is_zero(); 40 !info.first_background_time;
30 41
31 return incomplete_parse_in_foreground || 42 return incomplete_parse_in_foreground ||
32 WasStartedInForegroundEventInForeground(parse_stop, info); 43 WasStartedInForegroundEventInForeground(parse_stop, info);
33 } 44 }
34 } // namespace page_load_metrics 45 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_util.h ('k') | components/page_load_metrics/common/page_load_timing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698