Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_util.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Need to add Optional changes as well in this issue otherwise bots fail in compilation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 5 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
10 #include "components/page_load_metrics/common/page_load_timing.h" 10 #include "components/page_load_metrics/common/page_load_timing.h"
11 11
12 namespace page_load_metrics { 12 namespace page_load_metrics {
13 13
14 bool WasStartedInForegroundEventInForeground(base::TimeDelta event, 14 bool WasStartedInForegroundEventInForeground(const base::TimeDelta& event,
15 const PageLoadExtraInfo& info) { 15 const PageLoadExtraInfo& info) {
16 return info.started_in_foreground && !event.is_zero() && 16 return info.started_in_foreground && !event.is_zero() &&
17 (info.first_background_time.is_zero() || 17 (!info.first_background_time ||
18 event < info.first_background_time); 18 event < info.first_background_time.value());
19 }
20
21 bool WasStartedInForegroundOptionalEventInForeground(
22 const base::Optional<base::TimeDelta>& event,
23 const PageLoadExtraInfo& info) {
24 return info.started_in_foreground && event &&
Bryan McQuade 2016/03/29 18:33:43 could this become: return event && WasStartedInFor
shivanisha 2016/03/29 18:54:25 Since WasStartedInForegroundEventInForeground is r
Bryan McQuade 2016/03/29 19:00:47 Ah, I missed that. Good catch. Thanks!
25 (!info.first_background_time ||
26 event.value() < info.first_background_time.value());
19 } 27 }
20 28
21 } // namespace page_load_metrics 29 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698