Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_observer.cc

Issue 1837233002: Optional <TimeDelta> since they may be non existent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Need to add Optional changes as well in this issue otherwise bots fail in compilation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 5 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
6 6
7 namespace page_load_metrics { 7 namespace page_load_metrics {
8 8
9 PageLoadExtraInfo::PageLoadExtraInfo( 9 PageLoadExtraInfo::PageLoadExtraInfo(
10 base::TimeDelta first_background_time, 10 base::Optional<base::TimeDelta> first_background_time,
11 base::TimeDelta first_foreground_time, 11 base::Optional<base::TimeDelta> first_foreground_time,
12 bool started_in_foreground, 12 bool started_in_foreground,
13 const GURL& committed_url, 13 const GURL& committed_url,
14 base::TimeDelta time_to_commit, 14 base::Optional<base::TimeDelta> time_to_commit,
15 UserAbortType abort_type, 15 UserAbortType abort_type,
16 base::TimeDelta time_to_abort) 16 base::Optional<base::TimeDelta> time_to_abort)
17 : first_background_time(first_background_time), 17 : first_background_time(first_background_time),
18 first_foreground_time(first_foreground_time), 18 first_foreground_time(first_foreground_time),
19 started_in_foreground(started_in_foreground), 19 started_in_foreground(started_in_foreground),
20 committed_url(committed_url), 20 committed_url(committed_url),
21 time_to_commit(time_to_commit), 21 time_to_commit(time_to_commit),
22 abort_type(abort_type), 22 abort_type(abort_type),
23 time_to_abort(time_to_abort) {} 23 time_to_abort(time_to_abort) {}
24 24
25 // Using Optional <T> for the fields made clang complaint about not having
26 // an explicit out-of-line destructor
27 PageLoadExtraInfo::~PageLoadExtraInfo() {}
25 } // namespace page_load_metrics 28 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698