Buffer UI navigation events in DataUseTabModel until rule fetch

chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/data_usage/external_data_use_observer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
@@ skipping 372 matching lines @@
 }
 
 // Tests the matching rule fetch behavior when the external control app is
 // installed and not installed. Matching rules should be fetched when control
 // app gets installed. If control app is installed and no valid rules are found,
 // matching rules are fetched on every navigation. Rules are not fetched if
 // control app is not installed  or if more than zero valid rules have been
 // fetched.
 TEST_F(ExternalDataUseObserverTest, MatchingRuleFetchOnControlAppInstall) {
   {
-    // Matching rules not fetched on navigation if control app is not installed.
+    // Matching rules not fetched on navigation if control app is not installed,
+    // and navigation events will be buffered.
     external_data_use_observer()->last_matching_rules_fetch_time_ =
         base::TimeTicks();
     external_data_use_observer()
         ->data_use_tab_model_->is_control_app_installed_ = false;
     base::HistogramTester histogram_tester;
     external_data_use_observer()->data_use_tab_model_->OnNavigationEvent(
         kDefaultTabId, DataUseTabModel::TRANSITION_LINK, GURL(kDefaultURL),
         std::string());
     base::RunLoop().RunUntilIdle();
     histogram_tester.ExpectTotalCount("DataUsage.MatchingRulesCount.Valid", 0);
+    EXPECT_EQ(1, external_data_use_observer()
+                     ->data_use_tab_model_->data_use_ui_navigations_->size());
+    external_data_use_observer()
+        ->data_use_tab_model_->data_use_ui_navigations_->clear();
   }
 
   {
     // Matching rules are fetched when control app is installed.
     base::HistogramTester histogram_tester;
     external_data_use_observer()
         ->data_use_tab_model_->OnControlAppInstallStateChange(true);
     base::RunLoop().RunUntilIdle();
     histogram_tester.ExpectTotalCount("DataUsage.MatchingRulesCount.Valid", 1);
+    EXPECT_FALSE(external_data_use_observer()
+                     ->data_use_tab_model_->data_use_ui_navigations_.get());
   }
 
   {
     // Matching rules fetched on every navigation if control app is installed
     // and zero rules are available.
     external_data_use_observer()->last_matching_rules_fetch_time_ =
         base::TimeTicks();
     base::HistogramTester histogram_tester;
     external_data_use_observer()->data_use_tab_model_->OnNavigationEvent(
         kDefaultTabId, DataUseTabModel::TRANSITION_LINK, GURL(kDefaultURL),
@@ skipping 208 matching lines @@
   // First data use report should be marked as timed out.
   histogram_tester.ExpectUniqueSample(
       "DataUsage.ReportSubmissionResult",
       ExternalDataUseObserver::DATAUSAGE_REPORT_SUBMISSION_TIMED_OUT, 1);
   histogram_tester.ExpectUniqueSample(
       "DataUsage.ReportSubmission.Bytes.TimedOut",
       default_upload_bytes() + default_download_bytes(), 1);
   histogram_tester.ExpectTotalCount(kUMAReportSubmissionDurationHistogram, 0);
 }
 
+// Tests that UI navigation events are buffered until control app not installed
+// callback is received.
+TEST_F(ExternalDataUseObserverTest,
+       ProcessBufferedNavigationEventsAfterControlAppNotInstalled) {
+  external_data_use_observer()->data_use_tab_model_->OnNavigationEvent(
+      kDefaultTabId, DataUseTabModel::TRANSITION_LINK, GURL(kDefaultURL),
+      std::string());
+  external_data_use_observer()->data_use_tab_model_->OnNavigationEvent(
+      kDefaultTabId, DataUseTabModel::TRANSITION_LINK, GURL(kDefaultURL),
+      std::string());
+  EXPECT_EQ(2, external_data_use_observer()
+                   ->data_use_tab_model_->data_use_ui_navigations_->size());
+  external_data_use_observer()
+      ->data_use_tab_model_->OnControlAppInstallStateChange(false);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_FALSE(external_data_use_observer()
+                   ->data_use_tab_model_->data_use_ui_navigations_.get());
+}
+
+// Tests that UI navigation events are buffered until control app is installed
+// and matching rules are fetched.
+TEST_F(ExternalDataUseObserverTest,
+       ProcessBufferedNavigationEventsAfterRuleFetch) {
+  external_data_use_observer()->data_use_tab_model_->is_control_app_installed_ =
+      false;
+  base::HistogramTester histogram_tester;
+  external_data_use_observer()->data_use_tab_model_->OnNavigationEvent(
+      kDefaultTabId, DataUseTabModel::TRANSITION_LINK, GURL(kDefaultURL),
+      std::string());
+  external_data_use_observer()->data_use_tab_model_->OnNavigationEvent(
+      kDefaultTabId, DataUseTabModel::TRANSITION_LINK, GURL(kDefaultURL),
+      std::string());
+  EXPECT_EQ(2, external_data_use_observer()
+                   ->data_use_tab_model_->data_use_ui_navigations_->size());
+  external_data_use_observer()
+      ->data_use_tab_model_->OnControlAppInstallStateChange(true);
+  base::RunLoop().RunUntilIdle();
+  histogram_tester.ExpectTotalCount("DataUsage.MatchingRulesCount.Valid", 3);
+  EXPECT_FALSE(external_data_use_observer()
+                   ->data_use_tab_model_->data_use_ui_navigations_.get());
+}
+
+// Tests that UI navigation events are buffered until the buffer reaches a
+// maximum imposed limit.
+TEST_F(ExternalDataUseObserverTest,
+       ProcessBufferedNavigationEventsAfterMaxLimit) {
+  const uint32_t kDefaultMaxNavigationEventsBuffered = 1000;
+  // Expect that the max imposed limit will be reached, and the buffer will be
+  // cleared.
+  for (size_t count = 1; count < kDefaultMaxNavigationEventsBuffered; ++count) {

[tbansal1, 2016/03/29 18:19:04]

start at 0?

[Raj, 2016/03/29 19:45:54]

Done.

+    external_data_use_observer()->data_use_tab_model_->OnNavigationEvent(
+        kDefaultTabId, DataUseTabModel::TRANSITION_LINK, GURL(kDefaultURL),
+        std::string());
+    if (!external_data_use_observer()
+             ->data_use_tab_model_->data_use_ui_navigations_) {
+      // The max limit is reached.
+      break;
+    }
+    EXPECT_EQ(count,
+              external_data_use_observer()
+                  ->data_use_tab_model_->data_use_ui_navigations_->size());
+  }
+  EXPECT_FALSE(external_data_use_observer()
+                   ->data_use_tab_model_->data_use_ui_navigations_.get());
+}
+
 }  // namespace android
 
 }  // namespace chrome