src/crankshaft/hydrogen-instructions.cc - Issue 1837163002: [crankshaft] Write fillers for folded old space allocations during verify-heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1837163002: [crankshaft] Write fillers for folded old space allocations during verify-heap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen-instructions.cc

diff --git a/src/crankshaft/hydrogen-instructions.cc b/src/crankshaft/hydrogen-instructions.cc

index 4df90877e31dc4bba42a2928858fbabc7afbe165..4014ccf1784014bbeb89e555aadafd261ae8295f 100644

--- a/src/crankshaft/hydrogen-instructions.cc

+++ b/src/crankshaft/hydrogen-instructions.cc

@@ -3258,7 +3258,7 @@ bool HAllocate::HandleSideEffectDominator(GVNFlag side_effect,

keep_new_space_iterable = keep_new_space_iterable || FLAG_verify_heap;

#endif

- if (keep_new_space_iterable && dominator_allocate->IsNewSpaceAllocation()) {

+ if (keep_new_space_iterable) {

Hannes Payer (out of office) 2016/03/29 10:53:52 please rename to keep_heap_iterable

Michael Lippautz 2016/03/29 10:57:00 Done.

dominator_allocate->MakePrefillWithFiller();

} else {

// TODO(hpayer): This is a short-term hack to make allocation mementos

« no previous file with comments | « no previous file | no next file » | no next file with comments »