Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1837163002:
[crankshaft] Write fillers for folded old space allocations during verify-heap (Closed)
|
Created:
4 years, 8 months ago by Michael Lippautz Modified:
4 years, 8 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[crankshaft] Write fillers for folded old space allocations during verify-heap
If we don't write fillers, we crash during PagedSpace verification when we try
to iterate over dead memory (unused folded allocation slots).
BUG=v8:4871, chromium:580959
LOG=N
Committed: https://crrev.com/e7cc6091f5432781ed0bcaeb359b464c880488e4
Cr-Commit-Position: refs/heads/master@{#35097}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed comment #Messages
Total messages: 23 (12 generated)
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
PTAL
Description was changed from ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocations). BUG=v8:4871,chromium:580959 LOG=N ========== to ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837163002/1
Description was changed from ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N ========== to ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871 LOG=N ==========
LGTM, one nit https://codereview.chromium.org/1837163002/diff/1/src/crankshaft/hydrogen-ins... File src/crankshaft/hydrogen-instructions.cc (right): https://codereview.chromium.org/1837163002/diff/1/src/crankshaft/hydrogen-ins... src/crankshaft/hydrogen-instructions.cc:3261: if (keep_new_space_iterable) { please rename to keep_heap_iterable
Description was changed from ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871 LOG=N ========== to ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N ==========
https://codereview.chromium.org/1837163002/diff/1/src/crankshaft/hydrogen-ins... File src/crankshaft/hydrogen-instructions.cc (right): https://codereview.chromium.org/1837163002/diff/1/src/crankshaft/hydrogen-ins... src/crankshaft/hydrogen-instructions.cc:3261: if (keep_new_space_iterable) { On 2016/03/29 10:53:52, Hannes Payer wrote: > please rename to keep_heap_iterable Done.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/1837163002/#ps20001 (title: "Addressed comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837163002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12931)
mlippautz@chromium.org changed reviewers: + jkummerow@chromium.org
jkummerow@: OWNERS review please. This should actually fix crbug.com/570305 (same scenario), which was merged into the general folding tracking bug.
lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837163002/20001
Message was sent while issue was closed.
Description was changed from ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N ========== to ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N ========== to ========== [crankshaft] Write fillers for folded old space allocations during verify-heap If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N Committed: https://crrev.com/e7cc6091f5432781ed0bcaeb359b464c880488e4 Cr-Commit-Position: refs/heads/master@{#35097} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e7cc6091f5432781ed0bcaeb359b464c880488e4 Cr-Commit-Position: refs/heads/master@{#35097} |
