Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1837113002: Remove WebAudio WTF Logging. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
tkent, Raymond Toy, hongchan
CC:
blink-reviews, chromium-reviews, hongchan, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebAudio WTF Logging. Replace one WebAudio logging with a VLOG(1) call. BUG=596760 Committed: https://crrev.com/2604104b57be7c7cb0b8e3a2582bedee861729a6 Cr-Commit-Position: refs/heads/master@{#383878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dtapuska
4 years, 8 months ago (2016-03-29 03:10:56 UTC) #3
tkent
Add WebAudio experts. I think replacing it is ok because there is only one instance. ...
4 years, 8 months ago (2016-03-29 03:15:13 UTC) #5
Raymond Toy
On 2016/03/29 03:15:13, tkent wrote: > Add WebAudio experts. > > I think replacing it ...
4 years, 8 months ago (2016-03-29 16:43:18 UTC) #6
Raymond Toy
A quick grep shows two more uses of WTF_LOG in modules/webaudio/MediaStreamAudioSourceNode.cpp. Should these be removed ...
4 years, 8 months ago (2016-03-29 16:44:08 UTC) #7
tkent
lgtm. On 2016/03/29 at 16:44:08, rtoy wrote: > A quick grep shows two more uses ...
4 years, 8 months ago (2016-03-30 00:14:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837113002/1
4 years, 8 months ago (2016-03-30 00:18:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 00:24:14 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 00:25:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2604104b57be7c7cb0b8e3a2582bedee861729a6
Cr-Commit-Position: refs/heads/master@{#383878}

Powered by Google App Engine
This is Rietveld 408576698