Make "webkit-patch pretty-diff" work under Cygwin

Make "webkit-patch pretty-diff" work under Cygwin

Cygwin file paths are not compatible with regular Windows applications.
This patch uses cygstart to translate and open the appropriate local
HTML file path in the system browser.

This logic has not been upstreamed into a Port class due to the
security risk of exposing cygstart.


BUG=598511

[alancutter (OOO until 2018), 2016-03-29 02:24:30]

alancutter@chromium.org changed reviewers:
+ noel@chromium.org

[alancutter (OOO until 2018), 2016-03-29 02:24:48]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 02:24:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837103002/1

[commit-bot: I haz the power, 2016-03-29 03:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 03:41:05]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-03-29 04:29:34]

Description was changed from

==========
Make "webkit-patch pretty-diff" work under cygwin

Cygwin file paths are not compatible with regular Windows applications,
this patch makes use of cygstart to do the translation and open the
appropriate local HTML file path in the system browser.

BUG=598511
==========

to

==========
Make "webkit-patch pretty-diff" work under cygwin

Cygwin file paths are not compatible with regular Windows applications.
This patch uses cygstart to translate and open the appropriate local
HTML file path in the system browser.

This logic has not been upstreamed into a Port class due to the
security risk of exposing cygstart.


BUG=598511
==========

[Noel Gordon, 2016-03-29 04:32:04]

LGTM

[Noel Gordon, 2016-03-29 04:33:40]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2016-03-29 04:34:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837103002/20001

[Noel Gordon, 2016-03-29 04:35:38]

This recovers the method used to open diffs in in the old perl script btw, open
(osx), start (win), cyg-start (cywin), xdg-open (linux).

[commit-bot: I haz the power, 2016-03-29 05:29:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 05:30:59]

Description was changed from

==========
Make "webkit-patch pretty-diff" work under cygwin

Cygwin file paths are not compatible with regular Windows applications.
This patch uses cygstart to translate and open the appropriate local
HTML file path in the system browser.

This logic has not been upstreamed into a Port class due to the
security risk of exposing cygstart.


BUG=598511
==========

to

==========
Make "webkit-patch pretty-diff" work under cygwin

Cygwin file paths are not compatible with regular Windows applications.
This patch uses cygstart to translate and open the appropriate local
HTML file path in the system browser.

This logic has not been upstreamed into a Port class due to the
security risk of exposing cygstart.

BUG=598511

Committed: https://crrev.com/09bdf7f4b023dd3c71ab9012a4abead59c6d4472
Cr-Commit-Position: refs/heads/master@{#383670}
==========

[commit-bot: I haz the power, 2016-03-29 05:31:00]

Patchset 2 (id:??) landed as
https://crrev.com/09bdf7f4b023dd3c71ab9012a4abead59c6d4472
Cr-Commit-Position: refs/heads/master@{#383670}

[alancutter (OOO until 2018), 2016-03-29 06:36:31]

Description was changed from

==========
Make "webkit-patch pretty-diff" work under cygwin

Cygwin file paths are not compatible with regular Windows applications.
This patch uses cygstart to translate and open the appropriate local
HTML file path in the system browser.

This logic has not been upstreamed into a Port class due to the
security risk of exposing cygstart.

BUG=598511

Committed: https://crrev.com/09bdf7f4b023dd3c71ab9012a4abead59c6d4472
Cr-Commit-Position: refs/heads/master@{#383670}
==========

to

==========
Make "webkit-patch pretty-diff" work under Cygwin

Cygwin file paths are not compatible with regular Windows applications.
This patch uses cygstart to translate and open the appropriate local
HTML file path in the system browser.

This logic has not been upstreamed into a Port class due to the
security risk of exposing cygstart.


BUG=598511
==========