Invalidate objects when their content box changes dimensions.

Invalidate border-box sized objects when their content box changes dimensions.

If an object uses box-sizing:border-box then we need to invalidate it for
painting when its content box dimensions change. Otherwise we won't paint
changes in the size of the content box.

BUG=597194
Committed: https://crrev.com/4245c9bdfe18f0331a8e064c935f2ffacf0ec906
Cr-Commit-Position: refs/heads/master@{#384983}

[rhogan, 2016-04-03 15:03:06]

robhogan@gmail.com changed reviewers:
+ wangxianzhu@chromium.org

[rhogan, 2016-04-03 15:04:35]

Description was changed from

==========
Invalidate objects when their content box changes dimensions.

BUG=597194
==========

to

==========
Invalidate border-box sized objects when their content box changes dimensions.

If an object uses box-sizing:border-box then we need to invalidate it for
painting when its content box dimensions change. Otherwise we won't paint
changes in the size of the content box.

BUG=597194
==========

[Xianzhu, 2016-04-04 03:55:45]

https://codereview.chromium.org/1837033002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html
(right):

https://codereview.chromium.org/1837033002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html:5:
transition: padding;
Is this needed?

https://codereview.chromium.org/1837033002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html:12:
<p>crbug.com/597194: There should be a blue box below.</p>
If the test fails, isn't there a blue box?
(In other words, can 'a blue box' indicate failure/success?)

https://codereview.chromium.org/1837033002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html:17:
document.body.offsetTop;
Nit: indent with 4 spaces.

https://codereview.chromium.org/1837033002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html:17:
document.body.offsetTop;
Nit: No need to force layout here because this is in runAfterLayoutAndPaint().

[rhogan, 2016-04-04 18:05:24]

On 2016/04/04 at 03:55:45, wangxianzhu wrote:
>
https://codereview.chromium.org/1837033002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html:17:
document.body.offsetTop;
> Nit: No need to force layout here because this is in runAfterLayoutAndPaint().

Thanks wangxianzhu - applied your changes.

[Xianzhu, 2016-04-04 18:20:41]

lgtm

https://codereview.chromium.org/1837033002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html
(right):

https://codereview.chromium.org/1837033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/repaint/border-box-sizing-invalidation.html:18:
}, true);
Nit: align with line 16.

[rhogan, 2016-04-04 18:24:54]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-04-04 18:24:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/1837033002/#ps40001
(title: "Updated")

[commit-bot: I haz the power, 2016-04-04 18:25:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837033002/40001

[commit-bot: I haz the power, 2016-04-04 19:44:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-04 19:45:28]

Description was changed from

==========
Invalidate border-box sized objects when their content box changes dimensions.

If an object uses box-sizing:border-box then we need to invalidate it for
painting when its content box dimensions change. Otherwise we won't paint
changes in the size of the content box.

BUG=597194
==========

to

==========
Invalidate border-box sized objects when their content box changes dimensions.

If an object uses box-sizing:border-box then we need to invalidate it for
painting when its content box dimensions change. Otherwise we won't paint
changes in the size of the content box.

BUG=597194

Committed: https://crrev.com/4245c9bdfe18f0331a8e064c935f2ffacf0ec906
Cr-Commit-Position: refs/heads/master@{#384983}
==========

[commit-bot: I haz the power, 2016-04-04 19:45:29]

Patchset 3 (id:??) landed as
https://crrev.com/4245c9bdfe18f0331a8e064c935f2ffacf0ec906
Cr-Commit-Position: refs/heads/master@{#384983}