Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: LayoutTests/fast/text/text-shadow-extreme-value.html

Issue 183703003: Remove more testRunner.display() calls from LayoutTests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Just delete an svg crash test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/text/text-shadow-extreme-value.html
diff --git a/LayoutTests/fast/text/text-shadow-extreme-value.html b/LayoutTests/fast/text/text-shadow-extreme-value.html
index 3530bc16c57069aa7212a0bcae82cadb1fc8c182..cb5c2f93b4fbd482df6405a4da246848cfdb5c84 100644
--- a/LayoutTests/fast/text/text-shadow-extreme-value.html
+++ b/LayoutTests/fast/text/text-shadow-extreme-value.html
@@ -1,13 +1,16 @@
<html>
<head>
<title>Test HTML Page</title>
+<script src="../../resources/run-after-display.js"></script>
<script>
function test()
{
if (window.testRunner) {
testRunner.dumpAsText();
- document.body.offsetTop;
- testRunner.display();
+ testRunner.waitUntilDone();
+ runAfterDisplay(function() {
jamesr 2014/02/27 21:41:05 nit: probably don't need the extra closure, "runAf
enne (OOO) 2014/02/27 22:50:16 You'd think that (and I did too), but the test tim
jamesr 2014/02/27 23:56:07 Hmm, maybe because testRunner is implemented with
enne (OOO) 2014/02/28 00:57:48 Yeah, I think that's my conclusion too. I changed
+ testRunner.notifyDone();
+ });
}
}
</script>

Powered by Google App Engine
This is Rietveld 408576698