LayoutTests/fast/text/chromium-mac-duplicate-ime-composition.html - Issue 183703003: Remove more testRunner.display() calls from LayoutTests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/text/chromium-mac-duplicate-ime-composition.html

Issue 183703003: Remove more testRunner.display() calls from LayoutTests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Just delete an svg crash test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/text/chromium-mac-duplicate-ime-composition.html

diff --git a/LayoutTests/fast/text/chromium-mac-duplicate-ime-composition.html b/LayoutTests/fast/text/chromium-mac-duplicate-ime-composition.html

index 5ea0ca8648bbc618a8ca7e181acdead1a1c89d66..f4c9b75c4253a10ba7ce7edc14e01f204a264a4e 100644

--- a/LayoutTests/fast/text/chromium-mac-duplicate-ime-composition.html

+++ b/LayoutTests/fast/text/chromium-mac-duplicate-ime-composition.html

@@ -1,5 +1,6 @@

<html>

<head>

+ <script src="../../resources/run-after-display.js"></script>

function check(expect, actual) {

var console = document.getElementById('console');

@@ -19,17 +20,18 @@

textarea.addEventListener('keydown', function (e) {

textarea.style['overflow'] = 'hidden';

});

- testRunner.display();

- textarea.focus();

- if (textInputController.setComposition) {

- // Emulates start input method conversion.

- textInputController.setComposition('first');

- // Then, emulates change of the composition text of the input method.

- textInputController.setComposition('second');

- // Checks whether the textarea does not contain the first composition.

- check('second', textarea.value);

- }

- testRunner.notifyDone();

+ runAfterDisplay(function() {

+ textarea.focus();

+ if (textInputController.setComposition) {

+ // Emulates start input method conversion.

+ textInputController.setComposition('first');

+ // Then, emulates change of the composition text of the input method.

+ textInputController.setComposition('second');

+ // Checks whether the textarea does not contain the first composition.

+ check('second', textarea.value);

+ }

+ testRunner.notifyDone();

+ });

}

</script>

</head>

« no previous file with comments | « LayoutTests/fast/table/empty-section-crash.html ('k') | LayoutTests/fast/text/font-initial.html » ('j') | LayoutTests/fast/text/font-initial.html » ('J')