LayoutTests/fast/text/text-shadow-extreme-value.html - Issue 183703003: Remove more testRunner.display() calls from LayoutTests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text/text-shadow-extreme-value.html

Issue 183703003: Remove more testRunner.display() calls from LayoutTests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Just delete an svg crash test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/text/font-initial.html ('K') | « LayoutTests/fast/text/font-initial.html ('k') | LayoutTests/http/tests/inspector/inspector-test.js » ('j') | LayoutTests/transitions/position-background-transition.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Test HTML Page</title>	3 <title>Test HTML Page</title>

	4 <script src="../../resources/run-after-display.js"></script>

4 <script>	5 <script>

5 function test()	6 function test()

6 {	7 {

7 if (window.testRunner) {	8 if (window.testRunner) {

8 testRunner.dumpAsText();	9 testRunner.dumpAsText();

9 document.body.offsetTop;	10 testRunner.waitUntilDone();

10 testRunner.display();	11 runAfterDisplay(function() {
	jamesr 2014/02/27 21:41:05 nit: probably don't need the extra closure, "runAf nit: probably don't need the extra closure, "runAfterDisplay(testRunner.notifyDone)" should be sufficient enne (OOO) 2014/02/27 22:50:16 You'd think that (and I did too), but the test tim Show quoted text On 2014/02/27 21:41:05, jamesr wrote: > nit: probably don't need the extra closure, > "runAfterDisplay(testRunner.notifyDone)" should be sufficient You'd think that (and I did too), but the test times out if I do that. I really don't understand. jamesr 2014/02/27 23:56:07 Hmm, maybe because testRunner is implemented with Show quoted text On 2014/02/27 22:50:16, enne wrote: > On 2014/02/27 21:41:05, jamesr wrote: > > nit: probably don't need the extra closure, > > "runAfterDisplay(testRunner.notifyDone)" should be sufficient > > You'd think that (and I did too), but the test times out if I do that. I really > don't understand. Hmm, maybe because testRunner is implemented with shitty NPAPI bindings that probably don't support binding properly. But I swear some other tests (the previous one?) was binding runAfterDisplay directly to testRunner.notifyDone. Any idea how that one works? enne (OOO) 2014/02/28 00:57:48 Yeah, I think that's my conclusion too. I changed Show quoted text On 2014/02/27 23:56:07, jamesr wrote: > On 2014/02/27 22:50:16, enne wrote: > > On 2014/02/27 21:41:05, jamesr wrote: > > > nit: probably don't need the extra closure, > > > "runAfterDisplay(testRunner.notifyDone)" should be sufficient > > > > You'd think that (and I did too), but the test times out if I do that. I > really > > don't understand. > > Hmm, maybe because testRunner is implemented with shitty NPAPI bindings that > probably don't support binding properly. But I swear some other tests (the > previous one?) was binding runAfterDisplay directly to testRunner.notifyDone. > Any idea how that one works? Yeah, I think that's my conclusion too. I changed the other occurrence to also use a closure for sanity.
	12 testRunner.notifyDone();

	13 });

11 }	14 }

12 }	15 }

13 </script>	16 </script>

14 <style type="text/css">	17 <style type="text/css">

15 p { text-shadow: purple 0px 0px 38005685px; }	18 p { text-shadow: purple 0px 0px 38005685px; }

16 </style>	19 </style>

17 </head>	20 </head>

18 <body onload="test()">	21 <body onload="test()">

19 <p>Extreme text-shadow blur values should not crash.</p>	22 <p>Extreme text-shadow blur values should not crash.</p>

20 </body>	23 </body>

21 </html>	24 </html>

OLD	NEW