Remove more testRunner.display() calls from LayoutTests

Remove more testRunner.display() calls from LayoutTests

These tests should continue to run correctly without rebaselines.

BUG=345027
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168232

[enne (OOO), 2014-02-27 19:57:47]

jamesr for review.

pfeldman/caseq for inspector tests FYI or review.  Many of these tests asked for
display(), but didn't actually seem to need it to generate the right inspector
results.  I don't know these tests very well though, so would appreciate a
sanity check.

https://codereview.chromium.org/183703003/diff/1/LayoutTests/fast/events/touc...
File LayoutTests/fast/events/touch/gesture/pad-gesture-cancel.js (left):

https://codereview.chromium.org/183703003/diff/1/LayoutTests/fast/events/touc...
LayoutTests/fast/events/touch/gesture/pad-gesture-cancel.js:1:
description("Tests basic use of GestureFlingCancel");
This was only used in one place, so moved it into the html file.

[enne (OOO), 2014-02-27 19:58:06]

Depends on https://codereview.chromium.org/181653006/ for runAfterDisplay.

[jamesr, 2014-02-27 21:41:05]

lgtm

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
File LayoutTests/fast/text/text-shadow-extreme-value.html (right):

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
LayoutTests/fast/text/text-shadow-extreme-value.html:11:
runAfterDisplay(function() {
nit: probably don't need the extra closure,
"runAfterDisplay(testRunner.notifyDone)" should be sufficient

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/transitions/...
File LayoutTests/transitions/position-background-transition.html (right):

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/transitions/...
LayoutTests/transitions/position-background-transition.html:22:
webkit.requestAnimationFrame();
webkit. ?

[enne (OOO), 2014-02-27 22:50:15]

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
File LayoutTests/fast/text/text-shadow-extreme-value.html (right):

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
LayoutTests/fast/text/text-shadow-extreme-value.html:11:
runAfterDisplay(function() {
On 2014/02/27 21:41:05, jamesr wrote:
> nit: probably don't need the extra closure,
> "runAfterDisplay(testRunner.notifyDone)" should be sufficient

You'd think that (and I did too), but the test times out if I do that.  I really
don't understand.

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/transitions/...
File LayoutTests/transitions/position-background-transition.html (right):

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/transitions/...
LayoutTests/transitions/position-background-transition.html:22:
webkit.requestAnimationFrame();
On 2014/02/27 21:41:05, jamesr wrote:
> webkit. ?

OOPS.  Deleted.

[jamesr, 2014-02-27 23:56:06]

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/fo...
File LayoutTests/fast/text/font-initial.html (right):

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/fo...
LayoutTests/fast/text/font-initial.html:11:
runAfterDisplay(testRunner.notifyDone);
this should be inside the window.testRunner check, right?

how does this binding work and the other one not?

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
File LayoutTests/fast/text/text-shadow-extreme-value.html (right):

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
LayoutTests/fast/text/text-shadow-extreme-value.html:11:
runAfterDisplay(function() {
On 2014/02/27 22:50:16, enne wrote:
> On 2014/02/27 21:41:05, jamesr wrote:
> > nit: probably don't need the extra closure,
> > "runAfterDisplay(testRunner.notifyDone)" should be sufficient
> 
> You'd think that (and I did too), but the test times out if I do that.  I
really
> don't understand.

Hmm, maybe because testRunner is implemented with shitty NPAPI bindings that
probably don't support binding properly. But I swear some other tests (the
previous one?) was binding runAfterDisplay directly to testRunner.notifyDone. 
Any idea how that one works?

[enne (OOO), 2014-02-28 00:57:47]

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
File LayoutTests/fast/text/text-shadow-extreme-value.html (right):

https://codereview.chromium.org/183703003/diff/30001/LayoutTests/fast/text/te...
LayoutTests/fast/text/text-shadow-extreme-value.html:11:
runAfterDisplay(function() {
On 2014/02/27 23:56:07, jamesr wrote:
> On 2014/02/27 22:50:16, enne wrote:
> > On 2014/02/27 21:41:05, jamesr wrote:
> > > nit: probably don't need the extra closure,
> > > "runAfterDisplay(testRunner.notifyDone)" should be sufficient
> > 
> > You'd think that (and I did too), but the test times out if I do that.  I
> really
> > don't understand.
> 
> Hmm, maybe because testRunner is implemented with shitty NPAPI bindings that
> probably don't support binding properly. But I swear some other tests (the
> previous one?) was binding runAfterDisplay directly to testRunner.notifyDone. 
> Any idea how that one works?

Yeah, I think that's my conclusion too.  I changed the other occurrence to also
use a closure for sanity.

[caseq, 2014-02-28 11:52:02]

devtools lgtm

[enne (OOO), 2014-02-28 18:50:31]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-02-28 18:50:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/183703003/70001

[commit-bot: I haz the power, 2014-02-28 20:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 20:36:23]

Retried try job too often on mac_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...

[enne (OOO), 2014-02-28 20:46:10]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-02-28 20:46:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/183703003/90001

[commit-bot: I haz the power, 2014-02-28 22:06:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 22:06:24]

Retried try job too often on blink_android_compile_rel for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...

[enne (OOO), 2014-02-28 22:32:40]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-02-28 22:33:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/183703003/110001

[commit-bot: I haz the power, 2014-02-28 23:49:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:49:17]

Retried try job too often on blink_android_compile_rel for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...

[enne (OOO), 2014-02-28 23:56:52]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:57:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/183703003/110001

[commit-bot: I haz the power, 2014-03-01 00:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 00:59:56]

Retried try job too often on blink_android_compile_rel for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...

[enne (OOO), 2014-03-01 02:44:57]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-03-01 02:45:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/183703003/110001

[commit-bot: I haz the power, 2014-03-01 02:46:25]

Change committed as 168232