Collect a single frame sample in the profiler if we can't validate stack boundaries

Collect a single frame sample in the profiler if we can't validate stack boundaries

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/35773929e42099013ea9c86c3d0b7f86f741e6a2

[Cutch, 2016-03-29 15:49:57]

Description was changed from

==========
Collect a single frame sample in the profiler if we can't validate stack
boundaries

BUG=
==========

to

==========
Collect a single frame sample in the profiler if we can't validate stack
boundaries

BUG=
==========

[Cutch, 2016-03-29 15:49:58]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[siva, 2016-03-29 17:12:27]

lgtm

[sra1, 2016-03-29 17:22:03]

On 2016/03/29 15:50:13, Cutch wrote:

How does this manifest in the Observatory cpu profile?

[sra1, 2016-03-29 17:22:17]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-03-29 17:22:18]

https://codereview.chromium.org/1837023003/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/1837023003/diff/1/runtime/vm/profiler.cc#newc...
runtime/vm/profiler.cc:1023: return;
Should this be sampled as a single frame too?

[Cutch, 2016-03-29 17:41:48]

On 2016/03/29 17:22:03, sra1 wrote:
> On 2016/03/29 15:50:13, Cutch wrote:
> 
> How does this manifest in the Observatory cpu profile?

These will show up as short call stacks.

[Cutch, 2016-03-29 17:43:18]

https://codereview.chromium.org/1837023003/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/1837023003/diff/1/runtime/vm/profiler.cc#newc...
runtime/vm/profiler.cc:1023: return;
On 2016/03/29 17:22:18, sra1 wrote:
> Should this be sampled as a single frame too?

Might as well.

[Cutch, 2016-03-29 17:46:45]

Description was changed from

==========
Collect a single frame sample in the profiler if we can't validate stack
boundaries

BUG=
==========

to

==========
Collect a single frame sample in the profiler if we can't validate stack
boundaries

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/35773929e42099013ea9c86c3d0b7f86f741e6a2
==========

[Cutch, 2016-03-29 17:46:46]

Committed patchset #2 (id:20001) manually as
35773929e42099013ea9c86c3d0b7f86f741e6a2 (presubmit successful).