Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1837003002: Add null check to ImeLollipopTest to address flake (Closed)

Created:
4 years, 8 months ago by gone
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check to ImeLollipopTest to address flake The function can return null but it's immediately trying to dereference it without checking. BUG=598401 Committed: https://crrev.com/26220ce2e7ccf3e45ffe48b5cd59312fd0b52d09 Cr-Commit-Position: refs/heads/master@{#383561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
gone
4 years, 8 months ago (2016-03-28 20:17:32 UTC) #2
gone
+aelias for OWNERS, +kinaba for test fix.
4 years, 8 months ago (2016-03-28 20:18:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837003002/1
4 years, 8 months ago (2016-03-28 20:19:02 UTC) #6
aelias_OOO_until_Jul13
lgtm
4 years, 8 months ago (2016-03-28 20:36:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837003002/1
4 years, 8 months ago (2016-03-28 20:37:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 21:05:53 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 21:06:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26220ce2e7ccf3e45ffe48b5cd59312fd0b52d09
Cr-Commit-Position: refs/heads/master@{#383561}

Powered by Google App Engine
This is Rietveld 408576698