Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 18370002: cc: Made use color estimator a const instead of a flag. (Closed)

Created:
7 years, 5 months ago by vmpstr
Modified:
7 years, 5 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: Made use color estimator a const instead of a flag. Color estimator has been running for some time now, and it seems to be stable. This change removes the piping of the flag down to where it's used. The flag is still in the code for easy debugging. R=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209568

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix cc_perftests compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M cc/base/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 7 chunks +5 lines, -6 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/tile_manager.h View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/resources/tile_manager.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vmpstr
Please take a look.
7 years, 5 months ago (2013-07-01 18:14:36 UTC) #1
reveman
lgtm
7 years, 5 months ago (2013-07-01 20:00:59 UTC) #2
vmpstr
+piman for chrome/browser/chromeos/login/ and content/ OWNER's review. Please take a look.
7 years, 5 months ago (2013-07-01 20:05:34 UTC) #3
piman
lgtm https://codereview.chromium.org/18370002/diff/1/cc/resources/raster_worker_pool.cc File cc/resources/raster_worker_pool.cc (right): https://codereview.chromium.org/18370002/diff/1/cc/resources/raster_worker_pool.cc#newcode22 cc/resources/raster_worker_pool.cc:22: const bool kUseColorEstimator = true; nit: do we ...
7 years, 5 months ago (2013-07-01 20:14:45 UTC) #4
vmpstr
https://codereview.chromium.org/18370002/diff/1/cc/resources/raster_worker_pool.cc File cc/resources/raster_worker_pool.cc (right): https://codereview.chromium.org/18370002/diff/1/cc/resources/raster_worker_pool.cc#newcode22 cc/resources/raster_worker_pool.cc:22: const bool kUseColorEstimator = true; On 2013/07/01 20:14:45, piman ...
7 years, 5 months ago (2013-07-01 20:22:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/18370002/1
7 years, 5 months ago (2013-07-01 20:38:15 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-01 20:58:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/18370002/21001
7 years, 5 months ago (2013-07-01 21:32:33 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 01:30:00 UTC) #9
Message was sent while issue was closed.
Change committed as 209568

Powered by Google App Engine
This is Rietveld 408576698