Fix bubble client area clipping regression.

ui/views/bubble/bubble_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_frame_view.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "build/build_config.h"
@@ skipping 121 matching lines @@
 
 gfx::Rect BubbleFrameView::GetWindowBoundsForClientBounds(
     const gfx::Rect& client_bounds) const {
   gfx::Size size(GetSizeForClientSize(client_bounds.size()));
   return bubble_border_->GetBounds(gfx::Rect(), size);
 }
 
 bool BubbleFrameView::GetClientMask(const gfx::Size& size,
                                     gfx::Path* path) const {
   const int radius = bubble_border_->GetBorderCornerRadius();
+  gfx::Insets content_insets = GetInsets();
+  // If the client bounds don't touch the edges, no need to mask.

[Evan Stade, 2016/03/29 01:27:58]

This additional early return is not necessary for correctness, it's just a perf
optimization to avoid clipping with AA if we don't need to.

+  if (content_insets.top() > radius && content_insets.left() > radius &&
+      content_insets.bottom() > radius && content_insets.right()) {

[msw, 2016/03/29 22:54:55]

Did you mean to check |content_insets.right() > radius|?
Maybe check if the min dimension (calculated here) is > radius?

[Evan Stade, 2016/03/29 23:04:41]

good idea, done.

+    return false;
+  }
   gfx::RectF rect((gfx::Rect(size)));

[msw, 2016/03/29 22:54:55]

nit: remove extra parens?

[Evan Stade, 2016/03/29 23:04:41]

that produces an error message:

../../ui/views/bubble/bubble_frame_view.cc:148:18: error: parentheses were
disambiguated as a function declaration [-Werror,-Wvexing-parse]
  gfx::RectF rect(gfx::Rect(size));
                 ^~~~~~~~~~~~~~~~~
../../ui/views/bubble/bubble_frame_view.cc:148:19: note: add a pair of
parentheses to declare a variable
  gfx::RectF rect(gfx::Rect(size));
                  ^

[msw, 2016/03/29 23:08:27]

Weird, but this seems familiar, and likely came up in another review. nbd, but
you could just pass the width/height to RectF(float width, float height).

-  rect.Inset(gfx::InsetsF(0.5f));
   path->addRoundRect(gfx::RectFToSkRect(rect), radius, radius);
   return true;
 }
 
 int BubbleFrameView::NonClientHitTest(const gfx::Point& point) {
   if (!bounds().Contains(point))
     return HTNOWHERE;
   if (close_->visible() && close_->GetMirroredBounds().Contains(point))
     return HTCLOSE;
 
@@ skipping 359 matching lines @@
   size.Enlarge(client_insets.width(), client_insets.height());
   size.SetToMax(gfx::Size(title_bar_width, 0));
 
   if (footnote_container_)
     size.Enlarge(0, footnote_container_->GetHeightForWidth(size.width()));
 
   return size;
 }
 
 }  // namespace views