components/test_runner/pixel_dump.cc - Issue 1836973003: Move download messages from Renderer to Frame filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/pixel_dump.cc

Issue 1836973003: Move download messages from Renderer to Frame filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments, merge Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/renderer_context_menu/render_view_context_menu_base.h ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/pixel_dump.cc

diff --git a/components/test_runner/pixel_dump.cc b/components/test_runner/pixel_dump.cc

index fc859d782c521dfe0b3f6e5ad5301692ce8874ad..2b2abfbf60b8ce3feba06bda1c92faa87bb80dd4 100644

--- a/components/test_runner/pixel_dump.cc

+++ b/components/test_runner/pixel_dump.cc

@@ -21,6 +21,7 @@

#include "third_party/WebKit/public/platform/WebMockClipboard.h"

#include "third_party/WebKit/public/platform/WebPoint.h"

#include "third_party/WebKit/public/web/WebFrame.h"

+#include "third_party/WebKit/public/web/WebLocalFrame.h"

#include "third_party/WebKit/public/web/WebPagePopup.h"

#include "third_party/WebKit/public/web/WebPrintParams.h"

#include "third_party/WebKit/public/web/WebView.h"

@@ -185,7 +186,9 @@ void CopyImageAtAndCapturePixels(

uint64_t sequence_number =

blink::Platform::current()->clipboard()->sequenceNumber(

blink::WebClipboard::Buffer());

- web_view->copyImageAt(blink::WebPoint(x, y));

+ // TODO(lukasza): Support image capture in OOPIFs for

+ // https://crbug.com/477150.

+ web_view->mainFrame()->toWebLocalFrame()->copyImageAt(blink::WebPoint(x, y));

if (sequence_number ==

blink::Platform::current()->clipboard()->sequenceNumber(

blink::WebClipboard::Buffer())) {