components/renderer_context_menu/render_view_context_menu_base.h - Issue 1836973003: Move download messages from Renderer to Frame filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 1836973003: Move download messages from Renderer to Frame filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | components/test_runner/pixel_dump.cc » ('j') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/render_view_context_menu_base.h

diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h

index 1249f7a854d401d32e43ba1e3920076885a5f5e6..82792dd1af2c1ec1236eaf42b483f870c48abc99 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.h

+++ b/components/renderer_context_menu/render_view_context_menu_base.h

@@ -160,6 +160,7 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

// TODO(oshima): Remove this.

virtual void AppendPlatformEditableItems() {}

+ // May return nullptr if the frame was deleted while the menu was open.

content::RenderFrameHost* GetRenderFrameHost();

bool IsCustomItemChecked(int id) const;