content/renderer/render_frame_impl.cc - Issue 1836973003: Move download messages from Renderer to Frame filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1836973003: Move download messages from Renderer to Frame filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_message_filter.h ('K') | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.cc » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 1218cb618dfc6964dd450fd4c2f544e594c7c667..80c77d7ba0b199c6377d93da7fc27608b66ae17a 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -2796,10 +2796,9 @@ void RenderFrameImpl::loadURLExternally(const blink::WebURLRequest& request,

bool should_replace_current_entry) {

Referrer referrer(RenderViewImpl::GetReferrerFromRequest(frame_, request));

if (policy == blink::WebNavigationPolicyDownload) {

- render_view_->Send(new ViewHostMsg_DownloadUrl(render_view_->GetRoutingID(),

- GetRoutingID(),

- request.url(), referrer,

- suggested_name));

+ Send(new FrameHostMsg_DownloadUrl(render_view_->GetRoutingID(),

+ GetRoutingID(), request.url(), referrer,

+ suggested_name));

} else {

OpenURL(request.url(), referrer, policy, should_replace_current_entry,

false);