Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/public/web/WebFrame.h

Issue 1836973003: Move download messages from Renderer to Frame filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 // Returns the bounds rect for current selection. If selection is performed 531 // Returns the bounds rect for current selection. If selection is performed
532 // on transformed text, the rect will still bound the selection but will 532 // on transformed text, the rect will still bound the selection but will
533 // not be transformed itself. If no selection is present, the rect will be 533 // not be transformed itself. If no selection is present, the rect will be
534 // empty ((0,0), (0,0)). 534 // empty ((0,0), (0,0)).
535 virtual WebRect selectionBoundsRect() const = 0; 535 virtual WebRect selectionBoundsRect() const = 0;
536 536
537 // Only for testing purpose: 537 // Only for testing purpose:
538 // Returns true if selection.anchorNode has a marker on range from |from| wi th |length|. 538 // Returns true if selection.anchorNode has a marker on range from |from| wi th |length|.
539 virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const = 0; 539 virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const = 0;
540 540
541 // Copy to the clipboard the image located at a particular point in visual
542 // viewport coordinates.
543 virtual void copyImageAt(const WebPoint&) = 0;
Charlie Reis 2016/05/13 21:50:22 Do these need to live on WebFrame, or can they jus
brettw 2016/06/06 23:24:25 Nothing else follows this pattern (WebLocal frame
Charlie Reis 2016/06/07 22:51:25 I don't follow. WebLocalFrame has lots of things
dcheng 2016/06/08 16:00:35 These should be on WebLocalFrame: this is consiste
brettw 2016/06/09 23:41:00 Ah, when I read it I confused "= 0" with "override
544
545 // Save as the image located at a particular point in visual viewport
546 // coordinates.
547 virtual void saveImageAt(const WebPoint&) = 0;
548
541 // Dumps the layer tree, used by the accelerated compositor, in 549 // Dumps the layer tree, used by the accelerated compositor, in
542 // text form. This is used only by layout tests. 550 // text form. This is used only by layout tests.
543 virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0; 551 virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0;
544 552
545 virtual WebFrameImplBase* toImplBase() = 0; 553 virtual WebFrameImplBase* toImplBase() = 0;
546 // TODO(dcheng): Fix const-correctness issues and remove this overload. 554 // TODO(dcheng): Fix const-correctness issues and remove this overload.
547 virtual const WebFrameImplBase* toImplBase() const 555 virtual const WebFrameImplBase* toImplBase() const
548 { 556 {
549 return const_cast<WebFrame*>(this)->toImplBase(); 557 return const_cast<WebFrame*>(this)->toImplBase();
550 } 558 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 WebFrame* m_firstChild; 606 WebFrame* m_firstChild;
599 WebFrame* m_lastChild; 607 WebFrame* m_lastChild;
600 608
601 WebFrame* m_opener; 609 WebFrame* m_opener;
602 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker; 610 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker;
603 }; 611 };
604 612
605 } // namespace blink 613 } // namespace blink
606 614
607 #endif 615 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698