Move download messages from Renderer to Frame filter.

content/browser/frame_host/render_frame_message_filter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_MESSAGE_FILTER_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_MESSAGE_FILTER_H_
 
 #include <stdint.h>
 
 #include <set>
@@ skipping 13 matching lines @@
 class GURL;
 
 namespace net {
 class URLRequestContext;
 class URLRequestContextGetter;
 }
 
 namespace content {
 class BrowserContext;
 class PluginServiceImpl;
+struct Referrer;

[Charlie Reis, 2016/05/13 21:50:22]

nit: structs after classes, right?

[asanka, 2016/05/18 16:26:53]

Hm. I've also been sorting by identifier ignoring the class/struct, though I
can't find anything in the style guide that supports this.

[dcheng, 2016/05/24 07:18:08]

I also sort it by identifier, ignoring class name. IMO, this is consistent with
how #include / #imports are sorted by the path.

 class RenderWidgetHelper;
 class ResourceContext;
 struct WebPluginInfo;
 
 // RenderFrameMessageFilter intercepts FrameHost messages on the IO thread
 // that require low-latency processing. The canonical example of this is
 // child-frame creation which is a sync IPC that provides the renderer
 // with the routing id for a newly created RenderFrame.
 //
 // This object is created on the UI thread and used on the IO thread.
 class RenderFrameMessageFilter : public BrowserMessageFilter {
  public:
   RenderFrameMessageFilter(int render_process_id,
                            PluginServiceImpl* plugin_service,
                            BrowserContext* browser_context,
                            net::URLRequestContextGetter* request_context,
                            RenderWidgetHelper* render_widget_helper);
 
   // BrowserMessageFilter methods:
   bool OnMessageReceived(const IPC::Message& message) override;
 
+ protected:
+  // This method will be overridden by TestSaveImageFromDataURL class for test.
+  virtual void DownloadUrl(int render_view_id,
+                           int render_frame_id,
+                           const GURL& url,
+                           const Referrer& referrer,
+                           const base::string16& suggested_name,
+                           const bool use_prompt) const;
+
  private:
   class OpenChannelToPpapiPluginCallback;
   class OpenChannelToPpapiBrokerCallback;
 
   ~RenderFrameMessageFilter() override;
 
   void OnCreateChildFrame(const FrameHostMsg_CreateChildFrame_Params& params,
                           int* new_render_frame_id);
   void OnSetCookie(int render_frame_id,
                    const GURL& url,
@@ skipping 13 matching lines @@
                              const GURL& url,
                              const GURL& first_party_for_cookies,
                              IPC::Message* reply_msg,
                              const net::CookieList& cookie_list);
 
   // Writes the cookies to reply messages, and sends the message.
   // Callback functions for getting cookies from cookie store.
   void SendGetCookiesResponse(IPC::Message* reply_msg,
                               const std::string& cookies);
 
+  void OnDownloadUrl(int render_view_id,
+                     int render_frame_id,
+                     const GURL& url,
+                     const Referrer& referrer,
+                     const base::string16& suggested_name);
+  void OnSaveImageFromDataURL(int render_view_id,
+                              int render_frame_id,
+                              const std::string& url_str);
+
   void OnAre3DAPIsBlocked(int render_frame_id,
                           const GURL& top_origin_url,
                           ThreeDAPIType requester,
                           bool* blocked);
 
   void OnRenderProcessGone();
 
 #if defined(ENABLE_PLUGINS)
   void OnGetPlugins(bool refresh, IPC::Message* reply_msg);
   void GetPluginsCallback(IPC::Message* reply_msg,
@@ skipping 46 matching lines @@
 
   // Whether this process is used for incognito contents.
   bool incognito_;
 
   const int render_process_id_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_MESSAGE_FILTER_H_