Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: tools/perf/benchmarks/smoothness.py

Issue 1836973002: Disabled more reference builds on the Nexus5X due to the TimeoutException error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/service_worker.py ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/smoothness.py
diff --git a/tools/perf/benchmarks/smoothness.py b/tools/perf/benchmarks/smoothness.py
index 526350bbe3cdad555a5b9e25012736b546a14663..f9702a7e020c22868bddc0113f1525724bdeb9ce 100644
--- a/tools/perf/benchmarks/smoothness.py
+++ b/tools/perf/benchmarks/smoothness.py
@@ -48,6 +48,11 @@ class SmoothnessTop25(_Smoothness):
def Name(cls):
return 'smoothness.top_25_smooth'
+ @classmethod
+ def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
+ return (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
+
class SmoothnessToughFiltersCases(_Smoothness):
"""Measures frame rate and a variety of other statistics.
@@ -128,6 +133,10 @@ class SmoothnessKeyMobileSites(_Smoothness):
def Name(cls):
return 'smoothness.key_mobile_sites_smooth'
+ @classmethod
+ def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
+ return (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
@benchmark.Disabled('android') # crbug.com/589580
@benchmark.Disabled('android-reference') # crbug.com/588786
@@ -182,6 +191,11 @@ class SmoothnessGpuRasterizationTop25(_Smoothness):
def Name(cls):
return 'smoothness.gpu_rasterization.top_25_smooth'
+ @classmethod
+ def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
+ return (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
+
# crbug.com/589580 (This test should only be enabled on Android after fix.)
@benchmark.Disabled('all')
@@ -245,6 +259,11 @@ class SmoothnessSyncScrollKeyMobileSites(_Smoothness):
def Name(cls):
return 'smoothness.sync_scroll.key_mobile_sites_smooth'
+ @classmethod
+ def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
+ return (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
+
@benchmark.Enabled('android')
class SmoothnessSimpleMobilePages(_Smoothness):
« no previous file with comments | « tools/perf/benchmarks/service_worker.py ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698