tools/perf/benchmarks/power.py - Issue 1836973002: Disabled more reference builds on the Nexus5X due to the TimeoutException error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/power.py

Issue 1836973002: Disabled more reference builds on the Nexus5X due to the TimeoutException error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/power.py

diff --git a/tools/perf/benchmarks/power.py b/tools/perf/benchmarks/power.py

index f68de9849470f9feac6e5928de25810c0098f4a3..9061ee1b490aae6b641e0e458ba42a6741960667 100644

--- a/tools/perf/benchmarks/power.py

+++ b/tools/perf/benchmarks/power.py

@@ -58,7 +58,10 @@ class PowerToughAdCases(perf_benchmark.PerfBenchmark):

@classmethod

def ShouldDisable(cls, possible_browser):

- return cls.IsSvelte(possible_browser) # http://crbug.com/593973

+ # http://crbug.com/563968, http://crbug.com/593973

+ return (cls.IsSvelte(possible_browser) or

+ (possible_browser.browser_type == 'reference' and

+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'))

@benchmark.Enabled('android')

@@ -93,7 +96,10 @@ class PowerGpuRasterizationTypical10Mobile(perf_benchmark.PerfBenchmark):

@classmethod

def ShouldDisable(cls, possible_browser):

- return cls.IsSvelte(possible_browser) # http://crbug.com/563968

+ # http://crbug.com/563968, http://crbug.com/593973

+ return (cls.IsSvelte(possible_browser) or

+ (possible_browser.browser_type == 'reference' and

+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'))

@benchmark.Enabled('mac')

« no previous file with comments | « tools/perf/benchmarks/page_cycler.py ('k') | tools/perf/benchmarks/service_worker.py » ('j') | no next file with comments »