Handle invalid CFStrings in GetHFSDecomposedForm()

base/files/file_path_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <sstream>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
@@ skipping 1277 matching lines @@
 
 // Test the PrintTo overload for FilePath (used when a test fails to compare two
 // FilePaths).
 TEST_F(FilePathTest, PrintTo) {
   std::stringstream ss;
   FilePath fp(FPL("foo"));
   base::PrintTo(fp, &ss);
   EXPECT_EQ("foo", ss.str());
 }
 
+// Test GetHFSDecomposedForm should return empty result for invalid UTF-8
+// strings.
+#if defined(OS_MACOSX)
+TEST_F(FilePathTest, GetHFSDecomposedFormWithInvalidInput) {
+  const struct UnaryBooleanTestData cases[] = {

[Lei Zhang, 2016/03/30 21:53:08]

You are not using UnaryBooleanTestData's |expected| member at all. Just make
this a const FilePath::CharType* const array?

[Jialiu Lin, 2016/03/31 00:44:51]

Done

+    { FPL("\xc3\x28"),         true },
+    { FPL("\xe2\x82\x28"),     true },
+    { FPL("\xe2\x28\xa1"),     true },
+    { FPL("\xf0\x28\x8c\xbc"), true },
+    { FPL("\xf0\x28\x8c\x28"), true },
+  };
+  for (size_t i = 0; i < arraysize(cases); i++) {

[Lei Zhang, 2016/03/30 21:53:08]

You can probably slightly simplify this to:

for (const auto& test_case : cases) {
  FilePath::StringType observed = FilePath::GetHFSDecomposedForm(test_case);
  EXPECT_TRUE(observed.empty());
}

[Jialiu Lin, 2016/03/31 00:44:51]

Done

+    FilePath::StringPieceType invalid_input(cases[i].input);
+    FilePath::StringType observed = FilePath::GetHFSDecomposedForm(
+        invalid_input);
+    EXPECT_TRUE(observed.empty());
+  }
+}
+#endif
+
 }  // namespace base