Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1836883002: [Android] Switch instrumentation tests to platform mode. (RELAND) (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch instrumentation tests to platform mode. (RELAND) This is a reland of https://codereview.chromium.org/1387933005/ BUG=428729 Committed: https://crrev.com/a46e07369fc36afae9fab7506640eb76ff9b925a Cr-Commit-Position: refs/heads/master@{#383729}

Patch Set 1 #

Patch Set 2 : update CommandLineInitUtilTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M base/android/javatests/src/org/chromium/base/CommandLineInitUtilTest.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +6 lines, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/test_runner.py View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
jbudorick
4 years, 8 months ago (2016-03-28 18:58:55 UTC) #2
rnephew (Reviews Here)
On 2016/03/28 18:58:55, jbudorick wrote: lgtm
4 years, 8 months ago (2016-03-28 19:03:36 UTC) #3
mikecase (-- gone --)
lgtm You already know this, but I have code in infra that will save per-step ...
4 years, 8 months ago (2016-03-28 21:03:47 UTC) #4
jbudorick
On 2016/03/28 21:03:47, mikecase wrote: > lgtm > > You already know this, but I ...
4 years, 8 months ago (2016-03-28 21:22:07 UTC) #5
jbudorick
4 years, 8 months ago (2016-03-28 21:22:49 UTC) #7
jbudorick
On 2016/03/28 21:03:47, mikecase wrote: > lgtm > > You already know this, but I ...
4 years, 8 months ago (2016-03-28 21:23:05 UTC) #8
jbudorick
+yfriedman for base/android/ OWNERS
4 years, 8 months ago (2016-03-28 21:43:47 UTC) #10
Yaron
lgtm
4 years, 8 months ago (2016-03-29 14:18:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836883002/20001
4 years, 8 months ago (2016-03-29 14:31:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 15:34:30 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a46e07369fc36afae9fab7506640eb76ff9b925a Cr-Commit-Position: refs/heads/master@{#383729}
4 years, 8 months ago (2016-03-29 15:36:03 UTC) #16
jbudorick
4 years, 8 months ago (2016-03-29 17:41:36 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1843713002/ by jbudorick@chromium.org.

The reason for reverting is: broke mojo on Android GN:
https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/33530.

Powered by Google App Engine
This is Rietveld 408576698