Change VkPipelineStateCahce to use Hash and LRU LList.

Change VkPipelineStateCahce to use Hash and LRU LList.

This simplifies the caching code and forms the base for a caching template
that will be easier to use for other objects within Vulkan.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1836863002

Committed: https://skia.googlesource.com/skia/+/af132770a9462f6bb9cff47254e44675d9241fe8

[egdaniel, 2016-03-28 14:23:00]

Description was changed from

==========
Change VkPipelineStateCahce to use Hash and LRU LList.

This simplifies the caching code and forms the base for a caching template
that will be easier to use for other objects within Vulkan.

BUG=skia:
==========

to

==========
Change VkPipelineStateCahce to use Hash and LRU LList.

This simplifies the caching code and forms the base for a caching template
that will be easier to use for other objects within Vulkan.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2016-03-28 14:38:34]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[bsalomon, 2016-03-28 14:51:58]

https://codereview.chromium.org/1836863002/diff/80001/src/gpu/vk/GrVkGpu.h
File src/gpu/vk/GrVkGpu.h (right):

https://codereview.chromium.org/1836863002/diff/80001/src/gpu/vk/GrVkGpu.h#ne...
src/gpu/vk/GrVkGpu.h:167: sk_sp<GrVkPipelineState>* pipelineState);
why not just return a sk_sp<GrVkPipelineState>?

[egdaniel, 2016-03-28 18:14:46]

https://codereview.chromium.org/1836863002/diff/80001/src/gpu/vk/GrVkGpu.h
File src/gpu/vk/GrVkGpu.h (right):

https://codereview.chromium.org/1836863002/diff/80001/src/gpu/vk/GrVkGpu.h#ne...
src/gpu/vk/GrVkGpu.h:167: sk_sp<GrVkPipelineState>* pipelineState);
On 2016/03/28 14:51:58, bsalomon wrote:
> why not just return a sk_sp<GrVkPipelineState>?

Done.

[bsalomon, 2016-03-28 18:44:29]

lgtm w/ question about macro definition

https://codereview.chromium.org/1836863002/diff/100001/src/gpu/vk/GrVkResourc...
File src/gpu/vk/GrVkResourceProvider.h (right):

https://codereview.chromium.org/1836863002/diff/100001/src/gpu/vk/GrVkResourc...
src/gpu/vk/GrVkResourceProvider.h:87: #define PIPELINE_STATE_CACHE_STATS
Is this right? Should we really have a unprefixed macro defined in the middle of
a class?

[egdaniel, 2016-03-28 18:56:39]

https://codereview.chromium.org/1836863002/diff/100001/src/gpu/vk/GrVkResourc...
File src/gpu/vk/GrVkResourceProvider.h (right):

https://codereview.chromium.org/1836863002/diff/100001/src/gpu/vk/GrVkResourc...
src/gpu/vk/GrVkResourceProvider.h:87: #define PIPELINE_STATE_CACHE_STATS
On 2016/03/28 18:44:29, bsalomon wrote:
> Is this right? Should we really have a unprefixed macro defined in the middle
of
> a class?

I'm really not sure what our style for this is. I was following GrGLGpu.h's
model for PROGRAM_CACHE_STATS, but happy to add a GR in front since it is
probably safer.

[egdaniel, 2016-03-28 19:24:45]

https://codereview.chromium.org/1836863002/diff/100001/src/gpu/vk/GrVkResourc...
File src/gpu/vk/GrVkResourceProvider.h (right):

https://codereview.chromium.org/1836863002/diff/100001/src/gpu/vk/GrVkResourc...
src/gpu/vk/GrVkResourceProvider.h:87: #define PIPELINE_STATE_CACHE_STATS
On 2016/03/28 18:56:39, egdaniel wrote:
> On 2016/03/28 18:44:29, bsalomon wrote:
> > Is this right? Should we really have a unprefixed macro defined in the
middle
> of
> > a class?
> 
> I'm really not sure what our style for this is. I was following GrGLGpu.h's
> model for PROGRAM_CACHE_STATS, but happy to add a GR in front since it is
> probably safer.

Done.

[egdaniel, 2016-03-28 19:24:49]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-03-28 19:24:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1836863002/#ps120001
(title: "update macro name")

[commit-bot: I haz the power, 2016-03-28 19:24:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1836863002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1836863002/120001

[commit-bot: I haz the power, 2016-03-28 19:39:32]

Description was changed from

==========
Change VkPipelineStateCahce to use Hash and LRU LList.

This simplifies the caching code and forms the base for a caching template
that will be easier to use for other objects within Vulkan.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change VkPipelineStateCahce to use Hash and LRU LList.

This simplifies the caching code and forms the base for a caching template
that will be easier to use for other objects within Vulkan.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/af132770a9462f6bb9cff47254e44675d9241fe8
==========

[commit-bot: I haz the power, 2016-03-28 19:39:33]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/af132770a9462f6bb9cff47254e44675d9241fe8